Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

WASIX #3422

Merged
merged 560 commits into from
Feb 23, 2023
Merged

WASIX #3422

merged 560 commits into from
Feb 23, 2023

Conversation

theduke
Copy link
Contributor

@theduke theduke commented Dec 13, 2022 •
edited
Loading

This pull request implements full WASIX support for Wasmer.

It includes many changes, which will be summarized when the PR is ready for review.

Closes #3387 . (subsumes #3389 )
Closes #3308

Followup issues:

syrusakbary
syrusakbary reviewed Dec 13, 2022
View reviewed changes
lib/api/src/js/trap.rs Outdated Show resolved Hide resolved
syrusakbary
syrusakbary reviewed Dec 13, 2022
View reviewed changes
lib/vm/src/memory.rs Outdated Show resolved Hide resolved
@theduke theduke mentioned this pull request Dec 13, 2022
Closed
theduke
theduke commented Dec 15, 2022
View reviewed changes
lib/cache/src/filesystem.rs Outdated Show resolved Hide resolved
lib/c-api/src/wasm_c_api/wasi/mod.rs Outdated Show resolved Hide resolved
lib/wasi/src/syscalls/wasi/fd_read.rs Show resolved Hide resolved
@theduke theduke force-pushed the wasix branch 2 times, most recently from 4070d8e to b8e170e Compare December 16, 2022 11:50
@Michael-F-Bryan Michael-F-Bryan mentioned this pull request Dec 20, 2022
Closed
ptitSeb
ptitSeb reviewed Dec 21, 2022
View reviewed changes
lib/api/src/sys/imports.rs Outdated Show resolved Hide resolved
@theduke theduke mentioned this pull request Dec 22, 2022
Closed
ptitSeb
ptitSeb reviewed Dec 23, 2022
View reviewed changes
lib/vfs/src/mem_fs/file_opener.rs Show resolved Hide resolved
lib/vfs/src/union_fs.rs Show resolved Hide resolved
john-sharratt and others added 17 commits January 4, 2023 10:14
@john-sharratt
Added more unit tests and confirmed the cache is now working properly…
1dad3dd 
… again
@john-sharratt
Added a hack so that the coreutils webc works again
2589031
@john-sharratt
Added a hack so that the coreutils webc works again
0562a2b
@john-sharratt
Added memory usage data so that it can be accounted for in the metrics
663e97c
@john-sharratt
Renamed the file system memory usage property
5d2767d
@john-sharratt
Renamed the file system memory usage property
82696df
@john-sharratt
Now using the tokio thread pool for faster spin up performance
a6da4ec
@john-sharratt
Reduced some of the verbose logging
4509546
@john-sharratt
Fixed an issue where file descriptors were being leaked in certain si…
91549d3 
…tuations
@john-sharratt
Reduced the verbose logging on the poll function
1d0c9d9
@john-sharratt
Reduced the verbose logging on the poll function
fe2fd24
@john-sharratt
Added more debug information for the polling
df30d25
@john-sharratt
Added more debug information for the polling
30b0207
@john-sharratt
Added a fix so multiple clocks dont get triggered
a6a0d65
@john-sharratt
Added a fix for the polling so that it does not lose write events
466082e
@theduke
wasix: Reuse same runtime in PluggableRuntimeImplementation
a5ccc44 
Prevent creating a new tokio runtime all the time
@theduke
wasix: Allow constructing a PluggableRuntime with existing task manager
d34ce88
@theduke theduke mentioned this pull request Feb 22, 2023
Closed
@theduke
wasi: Remove the hardcoded default boot from Console
675a7c2 
The Console previously had a hardcoded boot webc package with a specific
dash package published on the Wasmer registry.

This level of hardcoding is not desireable.

The boot package now has to be specified as an argument in the
constructor.
@theduke
tests: Disable a few flaky snapshot tests
1b6f443 
The disabled ones use threading and have non-deterministic output.
This was referenced Feb 22, 2023
Closed
Closed
theduke and others added 12 commits February 22, 2023 23:19
@theduke
Rename SpecialFile to DeviceFile
16e92ff 
Because some people don't like anything special in their code base...
@theduke
Disable tcp client snapshot test due to hangs on CI
134d2f6
@theduke
Ensure WasiEnv cleanup in CLI
df6434f
@theduke
tests: Skip stdin_stdout_sterr snapshot test on Windows/Mac
fc4d38f 
Hangs forever on those platforms
@theduke
tests: Snapshot limit dash to Linux
6ac7a2d
@theduke
tests: Ignore the sleep snapshot test on non-linux
74f2d18 
Hangs indefinitely
@ptitSeb
[CREATE-EXE] Link with Security framework when cross-compiling on mac…
5cf54b4 
…OS (and the framework definition is embedded in create-exe)
@theduke
tests: Ignore hanging test on Mac OS
b88966c
@theduke
docs: Remove invalid/misleading comment
265d9f6
@theduke
chore: Formatting
7779e2e
@theduke
wasi: Put a time limit on WasiEnv::cleanup to avoid infinite idling
8c2aad2
@theduke
deps(wasi): Activate tokio time feature
0a422d8 
This would previously already be pulled in automatically by
dependencies, but needs to be manually enabled for JS builds
@theduke theduke mentioned this pull request Feb 23, 2023
Closed
@theduke
HACK: Disable 3 create-exe integration tests
b9c7b81 
Just for the WASIX merge.

Must be fixed and re-enabled.

See #3615
@theduke theduke mentioned this pull request Feb 23, 2023
Closed
@theduke theduke merged commit 102faec into master Feb 23, 2023
@theduke theduke deleted the wasix branch February 23, 2023 19:57
This was referenced Feb 23, 2023
Closed
Merged
Closed
@Michael-F-Bryan Michael-F-Bryan mentioned this pull request Feb 24, 2023
Closed
This was referenced Feb 24, 2023
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@john-sharratt john-sharratt john-sharratt left review comments

@ptitSeb ptitSeb ptitSeb left review comments

@syrusakbary syrusakbary syrusakbary approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Fix and Update wasi-types Generation Add full WASIX support to Wasmer runtime
5 participants
@theduke @syrusakbary @ptitSeb @Michael-F-Bryan @john-sharratt